3.7 KiB
3.7 KiB
Review choices
Use this when the user asks how much review to run, how to get another pass, when to stop, why review is slow, or how to change review.
Review depth in bmad-build and bmad-build-auto
none: no reviewers. Reasonable for a throwaway prototype.quick: one reviewer checks acceptance criteria, the repo's agent rules, and bugs.thorough: four independent lenses covering the bare diff, edge cases, test gaps, and intent alignment.- Default:
quick.autofollows the route:quickforoneshot,thoroughforfull. The user picks by saying "quick", "thorough", or "skip review" when invoking. thoroughsuits a change that is unusually risky or makes many design decisions.- It fixes clear findings itself, asks the user when the intent cannot settle one, and logs pre-existing issues to
deferred-work.md.
Another pass, and when to stop
- After
bmad-build: handbmad-buildthe plan it left atbuilt. It goes straight to review and triage, at the depth named in the request, and can be repeated.bmad-builddoes not resume adoneplan; hand that one tobmad-code-review. - After
bmad-build-auto: dispatch itsbuiltplan again. - Worth it after material fixes, or when an unattended run set
followup_review_recommended. After athoroughbuild review it only repeats the same lenses. - The depth a build ran at, skipped included, is the user's choice and no reason for another pass.
- At the end of an epic,
bmad-retrospectiveis the thorough pass: it runs the review lenses over the epic's diff and proposes fixes as action items. - Stop when findings are mostly minor notes about unlikely corner cases.
- Real findings on a third pass point outside the change: a weak spec or unclear repo rules. Tell the user to fix that.
bmad-code-review
- Target: a PR, commit, branch, commit range, uncommitted changes, a pasted diff, or files.
- Tell the user to supply the intent: a plan, a spec, or a plain description. A ticket in review brings its plan. Without it the reviewers can only judge the diff against itself.
- Defaults to
thorough; "quick" uses one reviewer. Above about 3000 diff lines it offers to review in file groups. - Triage checks every finding against the code and rejects disproved ones, plus low ones whose fix would add complexity.
- Survivors become patch (a clear fix), defer (pre-existing or unverified), or decision needed (when the right fix depends on what you meant).
- The user chooses: apply all patches, walk through each, or leave them as action items in the plan's
## Code Reviewsection.
Why review is slow
- It is thorough on purpose and can take half an hour or more. Offer
quick. AGENTS.mdhas too many rules, or source files are very large. Reviewers read both.- The platform has no subagents or runs them one at a time.
bmad-walkthrough: the human reviews
Recommend it when a person must understand and accept a change: after a build, or on someone else's PR. It walks the change in blocks, intent first, and stays on a block until the user says it is done. It gives no severity and no verdict. Moves the user can pick:
- Thoughts: the agent's own read. Second opinion: a fresh subagent's read.
- Formal review: runs
bmad-code-reviewwhen installed. - Test: helps test the part. Drive: starts the app and says what to click.
- Wrap-up: proposes the follow-through, such as merging, and waits for a yes.
For specs and docs, bmad-review (core tools), if installed, reports findings and fixes nothing.
What bmad-customize can change
- The default depth, separately for
bmad-build,bmad-build-auto, andbmad-code-review. - The lenses: add, replace, disable, or run one on another model.
bmad-walkthrough: instructions at start, per block, and at wrap-up.